Skip to content

Fix env variable typo _AIRFLOW_WWW_USER_LASTNME#18727

Merged
kaxil merged 1 commit intoapache:mainfrom
brettpalmberg:fix_env_variable_AIRFLOW_WWW_USER_LASTNME
Oct 5, 2021
Merged

Fix env variable typo _AIRFLOW_WWW_USER_LASTNME#18727
kaxil merged 1 commit intoapache:mainfrom
brettpalmberg:fix_env_variable_AIRFLOW_WWW_USER_LASTNME

Conversation

@brettpalmberg
Copy link
Copy Markdown
Contributor

@brettpalmberg brettpalmberg commented Oct 5, 2021

Env Variable Fix: _AIRFLOW_WWW_USER_LASTNME ---> _AIRFLOW_WWW_USER_LASTNAME

closes #18716

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg Bot added area:dev-tools area:production-image Production image improvements and fixes labels Oct 5, 2021
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented Oct 5, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@github-actions github-actions Bot added the full tests needed We need to run full set of tests for this PR to merge label Oct 5, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 5, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@brettpalmberg brettpalmberg force-pushed the fix_env_variable_AIRFLOW_WWW_USER_LASTNME branch from a31d324 to 6528da6 Compare October 5, 2021 04:47
@kaxil kaxil merged commit cc52548 into apache:main Oct 5, 2021
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented Oct 5, 2021

Awesome work, congrats on your first merged pull request!

@kaxil
Copy link
Copy Markdown
Member

kaxil commented Oct 5, 2021

Thanks @brettpalmberg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:production-image Production image improvements and fixes full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/entrypoint Environment Variable Typo "_AIRFLOW_WWW_USER_LASTNME"

3 participants