Add example and documentation on the Apache Pinot provider #19191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Theofanis Despoudis <328805+theodesp@users.noreply.github.com>
Co-authored-by: Theofanis Despoudis <328805+theodesp@users.noreply.github.com>
sharon2719
requested review from
kaxil,
mik-laj and
vikramkoka
as code owners
0ex-d
reviewed
Oct 24, 2021
0ex-d
left a comment
0ex-d
left a comment
There was a problem hiding this comment.
Looking good, try to get some tests in.
Member
|
Is there an associating issue for this? If so, it'd be best to use a keyword to link this PR to the issue, so the issue can be automatically closed when this is merged. |
uranusjr
changed the title
Member
|
Also IIRC all example DAGs are automatically tested so this doesn't need a new separate test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.