[AIRFLOW-677] Kill task if it fails to heartbeat#1923
Closed
saguziel wants to merge 3 commits intoapache:masterfrom
Closed
[AIRFLOW-677] Kill task if it fails to heartbeat#1923saguziel wants to merge 3 commits intoapache:masterfrom
saguziel wants to merge 3 commits intoapache:masterfrom
Conversation
If there's a connection error while heartbeating, it should retry. Also, if it hasn't been able to heartbeat for a while, it should kill the child processes so that we don't have 2 of the same task running.
saguziel
force-pushed
the
kill_zombies
branch
2 times, most recently
from
d792fa7 to
ea58c6a
Compare
Current coverage is 66.56% (diff: 70.37%)@@ master #1923 diff @@
==========================================
Files 135 135
Lines 10133 10181 +48
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 6745 6777 +32
- Misses 3388 3404 +16
Partials 0 0
|
Contributor
|
LGTM (FYI this PR got reviewed internally at Airbnb by mistercrunch and myself to get to it's current state) Also note that the original owner of this PR is @plypaul |
Contributor
Author
|
this was merged in 2306892 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:
@mistercrunch @artwr @bolkedebruin @plypaul
Testing Done: