Fix dumping container logs on error#19645
Merged
Merged
Conversation
Member
Author
|
cc: @khalidmammadov |
Member
Author
|
You can see container logs nicely uploaded here: https://github.com/apache/airflow/actions/runs/1471691334 BTW. It would not help with diagnosing the problem we had - pinot logs are not showig anything suspicious. It looks like error was caused by bad health-check. I will add a |
When we optimized tests for memory use we added cleanup of all containers after each test suite. Unfortunately it caused dumping container logs to stop working because this dumping was done only only when the script was exiting. This PR moves dumping container logs to between the test run and cleanup, so that we can see the logs when there is a test failure. Related to: apache#19633 where the logs were not dumped and it made the analysis much more difficult.
potiuk
force-pushed
the
fix-dumping-container-logs-on-error
branch
from
36681f4 to
b71bf70
Compare
Member
Author
ashb
approved these changes
Nov 17, 2021
Member
ashb
left a comment
ashb
left a comment
There was a problem hiding this comment.
Yeah my change didn't work on timeout, likely because of this.
github-actions
Bot
added
the
full tests needed
Contributor
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
added a commit
that referenced
this pull request
Jan 22, 2022
When we optimized tests for memory use we added cleanup of all containers after each test suite. Unfortunately it caused dumping container logs to stop working because this dumping was done only only when the script was exiting. This PR moves dumping container logs to between the test run and cleanup, so that we can see the logs when there is a test failure. Related to: #19633 where the logs were not dumped and it made the analysis much more difficult. (cherry picked from commit 7cda7d4)
potiuk
added
the
changelog:skip
potiuk
added a commit
that referenced
this pull request
Jan 22, 2022
When we optimized tests for memory use we added cleanup of all containers after each test suite. Unfortunately it caused dumping container logs to stop working because this dumping was done only only when the script was exiting. This PR moves dumping container logs to between the test run and cleanup, so that we can see the logs when there is a test failure. Related to: #19633 where the logs were not dumped and it made the analysis much more difficult. (cherry picked from commit 7cda7d4)
jedcunningham
pushed a commit
that referenced
this pull request
Jan 27, 2022
When we optimized tests for memory use we added cleanup of all containers after each test suite. Unfortunately it caused dumping container logs to stop working because this dumping was done only only when the script was exiting. This PR moves dumping container logs to between the test run and cleanup, so that we can see the logs when there is a test failure. Related to: #19633 where the logs were not dumped and it made the analysis much more difficult. (cherry picked from commit 7cda7d4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we optimized tests for memory use we added cleanup of all
containers after each test suite. Unfortunately it caused
dumping container logs to stop working because this dumping was
done only only when the script was exiting.
This PR moves dumping container logs to between the test run and
cleanup, so that we can see the logs when there is a test failure.
Related to: #19633 where the logs were not dumped and it made the
analysis much more difficult.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.