Add more complete instruction for reproducing failed integration tests #19646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When integration tests are failing, breeze prints the exact reproduction step to recreate the same environment. However when integration tests were enabled it missed the --integration flags that were necessary to enable the integrations. This PR adds the --integration flags to the instructions and also adds the comment that Kerberos integration currently does not work with docker-compose v2.
Member
Author
|
cc: @khalidmammadov |
uranusjr
approved these changes
Nov 18, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
potiuk
deleted the
add-better-instructions-for-running-integration-tests
branch
potiuk
added a commit
that referenced
this pull request
Jan 22, 2022
#19646) When integration tests are failing, breeze prints the exact reproduction step to recreate the same environment. However when integration tests were enabled it missed the --integration flags that were necessary to enable the integrations. This PR adds the --integration flags to the instructions and also adds the comment that Kerberos integration currently does not work with docker-compose v2. (cherry picked from commit 7b700bb)
potiuk
added
the
changelog:skip
potiuk
restored the
add-better-instructions-for-running-integration-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When integration tests are failing, breeze prints the exact
reproduction step to recreate the same environment. However when
integration tests were enabled it missed the --integration
flags that were necessary to enable the integrations.
This PR adds the --integration flags to the instructions and also
adds the comment that Kerberos integration currently does not work
with docker-compose v2.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.