[AIRFLOW-728] Add Google BigQuery table sensor#1970
Closed
bodschut wants to merge 1 commit intoapache:masterfrom
Closed
[AIRFLOW-728] Add Google BigQuery table sensor#1970bodschut wants to merge 1 commit intoapache:masterfrom
bodschut wants to merge 1 commit intoapache:masterfrom
Conversation
Design a sensor that checks whether a certain table is present in bigquery. The sensor will accept the google cloud project id, bigquery dataset id and bigquery table id to check as parameters. Internally, it will use the bigquery hook to check for the existence of the table. Therefore a 'table_exists' method will be added to the existing Bigquery hook.
Current coverage is 67.01% (diff: 100%)@@ master #1970 diff @@
==========================================
Files 135 135
Lines 10255 10255
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6873 6872 -1
- Misses 3382 3383 +1
Partials 0 0
|
Contributor
|
For me this is a +1. @criccomini could you take a look. @bolkedebruin if Chris approves can we take it with the alpha? |
Contributor
|
@alexvanboxel sure. |
Contributor
|
@criccomini ping :) |
Contributor
|
Now if @criccomini doesn't look this one over by tonight I like to merge this one anyway so I can build a new version on-top of master for the final freeze. |
Contributor
|
Sorry all. Been side tracked on other stuff, but +1 anyway. :) |
alekstorm
pushed a commit
to alekstorm/incubator-airflow
that referenced
this pull request
Jun 1, 2017
Design a sensor that checks whether a certain table is present in bigquery. The sensor will accept the google cloud project id, bigquery dataset id and bigquery table id to check as parameters. Internally, it will use the bigquery hook to check for the existence of the table. Therefore a 'table_exists' method will be added to the existing Bigquery hook. Closes apache#1970 from bodschut/feature/bq_sensor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design a sensor that checks whether a certain table is present in bigquery. The sensor will
accept the google cloud project id, bigquery dataset id and bigquery table id to check as
parameters.
Internally, it will use the bigquery hook to check for the existence of the table.
Therefore a 'table_exists' method will be added to the existing Bigquery hook.
Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:
Testing Done: