Skip to content

Conversation

@josh-fell
Copy link
Contributor

@josh-fell josh-fell commented Nov 28, 2021

As part of #19803 the retries value in default_args for the "example_functions" DAG within the Google provider was improperly added as a string rather than an integer. This update yields the below warnings in CI when importing all Airflow classes:

 Importing package: airflow.providers.google.cloud.example_dags
  [2021-11-28 18:30:01,419] {baseoperator.py:607} WARNING - Implicitly converting 'retries' for <Task(CloudFunctionDeployFunctionOperator): gcf_deploy_task> from '\x1b[01m3\x1b[22m' to int
  [2021-11-28 18:30:01,421] {baseoperator.py:607} WARNING - Implicitly converting 'retries' for <Task(CloudFunctionDeployFunctionOperator): gcf_deploy2_task> from '\x1b[01m3\x1b[22m' to int
  [2021-11-28 18:30:01,422] {baseoperator.py:607} WARNING - Implicitly converting 'retries' for <Task(CloudFunctionInvokeFunctionOperator): invoke_task> from '\x1b[01m3\x1b[22m' to int
  [2021-11-28 18:30:01,424] {baseoperator.py:607} WARNING - Implicitly converting 'retries' for <Task(CloudFunctionDeleteFunctionOperator): gcf_delete_task> from '\x1b[01m3\x1b[22m' to int

This PR updates the datatype of the retries value.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@josh-fell josh-fell requested a review from turbaszek as a code owner November 28, 2021 18:43
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Nov 28, 2021
@josh-fell josh-fell changed the title Update default_args value in example_functions DAG from str to int Fix CI warnings when importing all Airflow classes Nov 28, 2021
@josh-fell josh-fell changed the title Fix CI warnings when importing all Airflow classes Fix CI warnings when importing Google provider example DAGs Nov 28, 2021
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Nov 28, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@eladkal eladkal merged commit e9e5309 into apache:main Nov 28, 2021
@josh-fell josh-fell deleted the google-example-functions-dag-default-args branch November 29, 2021 02:14
dillonjohnson pushed a commit to dillonjohnson/airflow that referenced this pull request Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants