[AIRFLOW-757] Set child_process_log_directory default more sensible #1995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default of child_process_log_directory was pointing to /tmp/airflow/logs/scheduler. This could take people by surprise as it is a non standard location and deviates from Airflow's other log folders.
Current coverage is 67.22% (diff: 100%)@@ master #1995 diff @@
==========================================
Files 135 135
Lines 10366 10366
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6970 6969 -1
- Misses 3396 3397 +1
Partials 0 0
|
Contributor
Author
|
@alexvanboxel would you mind reviewing this? |
Contributor
|
+1 |
Contributor
|
+2 |
Contributor
|
Should we start thinking about putting those in LGTM otherwise |
Contributor
|
+3 :) |
Contributor
Author
|
@artwr I think we need to rework logging entirely. It is a confusing mess imho :). But /var/log seems a great start. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default of child_process_log_directory was pointing to
/tmp/airflow/logs/scheduler. This could take people by surprise as
it is a non standard location and deviates from Airflow's other
log folders.
@criccomini @aoen @artwr