Order bug report fields by importance #19990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I like it. I wonder what others think? |
potiuk
approved these changes
Dec 2, 2021
github-actions
bot
added
the
okay to merge
|
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Member
|
I like it a lot actually :) |
Member
|
I think I'd rather see the Airflow version still at the top, otherwise I like it as well. |
Member
|
Good for me with Airflow version too. |
Contributor
Author
|
Moved the version dropdown to the top: |
potiuk
approved these changes
Dec 6, 2021
Member
|
Looks Great to me :) |
Member
|
@jedcunningham and others - any comments :), or shall we merge it? |
jedcunningham
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I felt the bug report form was confusing to read, because you start with some issue in mind, and first have to work through "what version", "what deployment", etc. before getting to actually reporting the bug.
This PR places "What happened", "What you expected to happen", "How to reproduce" at the top (and makes "What happened" a required field), which to me feels like a better order.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.