Skip to content

Conversation

@AnudeepKonaboina
Copy link

@AnudeepKonaboina AnudeepKonaboina commented Dec 3, 2021

Added a FilePatternSFTPSensor as the existing SFTP sensor doesn't have the capability of sensing a dir/path based on a file pattern and only senses if the exact path is given.

This FilePatternSFTPSensor senses for the pattern which is provided by the user and lists all the files in the path/dir which matches the pattern.

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 3, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@uranusjr
Copy link
Member

uranusjr commented Dec 3, 2021

Instead of introducing an entirely new sensor, I would combine this to the “regular” sensor. See #17937 for a similar design.

@AnudeepKonaboina
Copy link
Author

Instead of introducing an entirely new sensor, I would combine this to the “regular” sensor. See #17937 for a similar design.

Sure @uranusjr Thanks for adding me as your contributor and accepting my feature

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jan 18, 2022
@github-actions github-actions bot closed this Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants