[AIRFLOW-823] Allow specifying execution date in task_info API#2045
[AIRFLOW-823] Allow specifying execution date in task_info API#2045robin-miller-ow wants to merge 1 commit intomasterfrom unknown repository
Conversation
|
@robin-miller-ow I think this is the wrong approach to make the change. A DAG does not have an execution date, but a DagRun does. A Task does not have an execution_date but a TaskInstance does by inheriting it from the DagRun. So I would expect: to return the information you are looking for. |
|
@bolkedebruin That seems inconsistent to me. When I added a date into the tigger dag API, you said it should be sent in the data, not the URL, so I presume we'd still want to do that. If this is not the right URL, then based on the trigger dag URL, would: |
|
@robin-miller-ow that is actually unrelated: GET vs POST. So no that is not more consistent |
Codecov Report
@@ Coverage Diff @@
## master #2045 +/- ##
==========================================
+ Coverage 66.94% 67.16% +0.22%
==========================================
Files 140 142 +2
Lines 10635 10688 +53
==========================================
+ Hits 7120 7179 +59
+ Misses 3515 3509 -6
Continue to review full report at Codecov.
|
|
@bolkedebruin I think this is now as you would like. Please let me know if there are any further issues. |
|
LGTM |
Closes apache#2045 from robin-miller- ow/release/API_TaskInstanceInfo
Closes apache#2045 from robin-miller- ow/release/API_TaskInstanceInfo
Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:
Testing Done: