Skip to content

Conversation

@jedcunningham
Copy link
Member

I'm finding less and less each cycle 👍

@potiuk
Copy link
Member

potiuk commented Dec 21, 2021

Been there, done that.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Dec 21, 2021
@github-actions
Copy link

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk
Copy link
Member

potiuk commented Dec 21, 2021

BTW. At the moment you stop finding them, it's the time to start mentoring a Padawan.


```shell script
git push origin ${VERSION}
git push origin tag ${VERSION}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original should work too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, but this is safer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL this is a thing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git never ceases to amaze me. Every time I get to do something really complex in git, it really is just a matter of looking hard enough. There has ALWAYS been a one liner (even if a line is long) that does precisely what I wanted to do - no matter how complex the thing was.

@jedcunningham jedcunningham merged commit 81f92d6 into apache:main Dec 22, 2021
@jedcunningham jedcunningham deleted the release_docs branch December 22, 2021 15:38
@potiuk potiuk added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 22, 2022
@potiuk potiuk added this to the Airflow 2.2.4 milestone Jan 22, 2022
potiuk pushed a commit that referenced this pull request Jan 22, 2022
jedcunningham added a commit that referenced this pull request Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants