Skip to content

Conversation

@jlowin
Copy link
Member

@jlowin jlowin commented Feb 2, 2017

Dear Airflow Maintainers,

Please accept this PR that addresses the following issues:
https://issues.apache.org/jira/browse/AIRFLOW-828

Adds a configurable maximum size for XComs that is checked before pushing any XCom. An error is
raised if the maximum size is exceeded.

Testing Done:

  • Added unit tests

@jlowin
Copy link
Member Author

jlowin commented Feb 2, 2017

Waiting on #2049 to gain transparency into the Travis errors

@jlowin jlowin force-pushed the limit-xcom-size branch 2 times, most recently from 6f926bf to b2bb772 Compare February 8, 2017 13:35
@codecov-io
Copy link

codecov-io commented Feb 8, 2017

Codecov Report

Merging #2048 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #2048      +/-   ##
=========================================
+ Coverage    67.7%   67.7%   +<.01%     
=========================================
  Files         139     139              
  Lines       10579   10585       +6     
=========================================
+ Hits         7162    7167       +5     
- Misses       3417    3418       +1
Impacted Files Coverage Δ
airflow/configuration.py 84.42% <ø> (ø)
airflow/exceptions.py 100% <100%> (ø)
airflow/models.py 86.13% <100%> (-0.03%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eea5ff8...4fb76a8. Read the comment docs.

@jlowin
Copy link
Member Author

jlowin commented Feb 11, 2017

@mistercrunch mind taking a look at this to see if it addresses your concerns?

Adds a configurable maximum size for XComs that
is checked before pushing any XCom. An error is
raised if the maximum size is exceeded.
@r39132
Copy link
Contributor

r39132 commented Sep 6, 2018

@jlowin What do you want to do with this PR?

@jlowin
Copy link
Member Author

jlowin commented Sep 7, 2018

Closed bc stale!

@jlowin jlowin closed this Sep 7, 2018
@jlowin jlowin deleted the limit-xcom-size branch September 7, 2018 19:48
@r39132
Copy link
Contributor

r39132 commented Sep 7, 2018

@jlowin What do you want to do with the Jiras?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants