Add twine check for provider packages #20619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
add-twine-check-to-provider-tests
branch
from
9aac780 to
15dd8e9
Compare
Twine (which we use to upload packages to PyPI) has the ability to run checks of packages before uploading them. This allows to detect cases like when we are using forbidden directives in README.rst (which delayed slightly preparing the December 2021 provider packages and resulted in apache#20614 With this PR Twine check will be run for all packages in CI before we even attempt to merge such change that could break them.
potiuk
force-pushed
the
add-twine-check-to-provider-tests
branch
from
15dd8e9 to
edcd377
Compare
mik-laj
approved these changes
Jan 2, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
potiuk
added
the
changelog:skip
potiuk
added a commit
that referenced
this pull request
Jan 22, 2022
Twine (which we use to upload packages to PyPI) has the ability to run checks of packages before uploading them. This allows to detect cases like when we are using forbidden directives in README.rst (which delayed slightly preparing the December 2021 provider packages and resulted in #20614 With this PR Twine check will be run for all packages in CI before we even attempt to merge such change that could break them. (cherry picked from commit f011f66)
jedcunningham
pushed a commit
that referenced
this pull request
Jan 27, 2022
Twine (which we use to upload packages to PyPI) has the ability to run checks of packages before uploading them. This allows to detect cases like when we are using forbidden directives in README.rst (which delayed slightly preparing the December 2021 provider packages and resulted in #20614 With this PR Twine check will be run for all packages in CI before we even attempt to merge such change that could break them. (cherry picked from commit f011f66)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twine (which we use to upload packages to PyPI) has the
ability to run checks of packages before uploading them.
This allows to detect cases like when we are using forbidden
directives in README.rst (which delayed slightly preparing the
December 2021 provider packages and resulted in #20614
With this PR Twine check will be run for all packages in CI
before we even attempt to merge such change that could break
them.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.