Skip to content

Fix MyPy issues in AWS Sensors#20717

Merged
kaxil merged 2 commits intoapache:mainfrom
astronomer:mypy-airflow/providers/amazon/aws/sensors
Jan 6, 2022
Merged

Fix MyPy issues in AWS Sensors#20717
kaxil merged 2 commits intoapache:mainfrom
astronomer:mypy-airflow/providers/amazon/aws/sensors

Conversation

@rajaths010494
Copy link
Contributor

Fixed mypy issues in airflow/providers/amazon/aws/sensors


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

added new sessions as default variable for the method
Made Optional Iterable str to iterable string or empty
Changed optional dict to dict in sagemaker
@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:providers provider:amazon AWS/Amazon - related issues labels Jan 6, 2022
@kaxil kaxil changed the title Mypy airflow/providers/amazon/aws/sensors Fix MyPy issues in AWS Sensors Jan 6, 2022
@kaxil kaxil added the mypy Fixing MyPy problems after bumpin MyPy to 0.990 label Jan 6, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jan 6, 2022
@kaxil kaxil merged commit 51dc4fd into apache:main Jan 6, 2022
@kaxil kaxil deleted the mypy-airflow/providers/amazon/aws/sensors branch January 6, 2022 13:57
@kaxil kaxil mentioned this pull request Jan 6, 2022
10 tasks
@kaxil kaxil added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) mypy Fixing MyPy problems after bumpin MyPy to 0.990 okay to merge It's ok to merge this PR as it does not require more tests provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants