Snowflake Provider: Improve tests for Snowflake Hook #20745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:snowflake
Member
Author
This PR improves `test_run_storing_query_ids_extra` test for Snowflake Hook. - Redundant testing of `Snowflake.get_conn` (This is already tested in `test_get_conn_should_call_connect`) - The expected values were derived from input, so you can't easily fail the test ! I have passed expected results and input separately - We were passing duplicate values in `query_ids`. I have fixed that by changing the code to only access `cur.sfqid` once in a variable and reuse that variable for logging and returning. Co-Authored-By: bharanidharan14 <94612827+bharanidharan14@users.noreply.github.com>
kaxil
force-pushed
the
improve-snowflake-tests
branch
from
d39280e to
9eb461e
Compare
jedcunningham
approved these changes
Jan 7, 2022
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
eladkal
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves
test_run_storing_query_ids_extratest for Snowflake Hook.Snowflake.get_conn(This is already tested intest_get_conn_should_call_connect)query_ids. I have fixed that by changing the code to only accesscur.sfqidonce in a variable and reuse that variable for logging and returning.Co-authored-by: bharanidharan14 94612827+bharanidharan14@users.noreply.github.com
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.