[AIRFLOW-862] Fix Unit Tests for DaskExecutor#2076
[AIRFLOW-862] Fix Unit Tests for DaskExecutor#2076jlowin wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2076 +/- ##
==========================================
+ Coverage 66.67% 66.98% +0.31%
==========================================
Files 142 142
Lines 10725 10724 -1
==========================================
+ Hits 7151 7184 +33
+ Misses 3574 3540 -34
Continue to review full report at Codecov.
|
012a52f to
5fdfb7f
Compare
|
@jlowin looks good, can you investigate why postgres is failing on py3? Maybe unrelated, not sure. and maybe rebase to see if decrease in coverage and landscape errors will go away. |
|
@bolke weird error... seems unrelated. I'm guessing the coverage decrease is because the unit test I deleted had a failed task in it and the remaining one doesn't. I don't really see what else could have caused that (the two unit tests were almost identical otherwise). I'm not sure what landscape's issue is either, when I click details it says no problems. I'm going to rebase and push and let's see what happens! |
Unit tests were inadvertently disabled for DaskExecutor
5fdfb7f to
3de227c
Compare
|
LGTM |
Unit tests were inadvertently disabled for DaskExecutor Closes apache#2076 from jlowin/fix-dask-tests
Unit tests were inadvertently disabled for DaskExecutor added in #2067.
@bolkedebruin in reviewing the tests, I fixed the ImportError that caused them to be disabled, streamlined them slightly, and removed one that turned out to be useless without a
BackfillJobchecking the executor's event buffer -- that case is already covered by the Dask integration test.Dear Airflow Maintainers,
Please accept this PR that addresses the following issues: