Uses CI images built in previous step to prepare PROD image#20889
Merged
uranusjr merged 1 commit intoapache:mainfrom Jan 18, 2022
Merged
Conversation
PROD image building needs CI images in order to prepare provider packages needed to build PROD images. Those were taken from the "latest" image but should be taken from the CI image built in the previous step - the GITHUB_REGISTRY_PULL_IMAGE_TAG was pointing to latest. This was not a problem in vast majority of cases (it could only be problem if new dependencies were added which would break validation of dependencies in the CI image) or when you tried to push a change to the `main` branch in forked image and you never pushed a latest CI image there). This change sets GITHUB_REGISTRY_PULL_IMAGE_TAG to be the same as just used GITHUB_REGISTRY_PUSH_IMAGE_TAG to push the CI images - so it will always pull the CI images pushed in the previous job.
Member
Author
|
cc: @edithturn - this was the bug you discovered why testing #20701 in your fork. Good catch ! |
This was referenced Jan 15, 2022
Member
Author
|
@ashb @uranusjr @ephraimbuddy @mik-laj - this one needs to be merged to fix PROD build in #20910 |
potiuk
changed the title
mik-laj
approved these changes
Jan 18, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
potiuk
added
the
changelog:skip
potiuk
added a commit
that referenced
this pull request
Jan 22, 2022
(cherry picked from commit fce46e6)
jedcunningham
pushed a commit
that referenced
this pull request
Jan 27, 2022
(cherry picked from commit fce46e6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PROD image building needs CI images in order to prepare provider
packages needed to build PROD images. Those were taken from
the "latest" image but should be taken from the CI image built
in the previous step - the GITHUB_REGISTRY_PULL_IMAGE_TAG was
pointing to latest. This was not a problem in vast majority of
cases (it could only be problem if new dependencies were added
which would break validation of dependencies in the CI image)
or when you tried to push a change to the
mainbranch inforked image and you never pushed a latest CI image there).
This change sets GITHUB_REGISTRY_PULL_IMAGE_TAG to be the
same as just used GITHUB_REGISTRY_PUSH_IMAGE_TAG to push the
CI images - so it will always pull the CI images pushed in the
previous job.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.