Skip to content

Conversation

@edithturn
Copy link
Contributor

@edithturn edithturn commented Jan 19, 2022

This PR is to fix the one that was merged: #20763
Point:
The runners have different filesystems to check the disk available. The one that is mounted should be taken to extract data of the disk available in the runners.

Please keep in mind it is a work in progress this is Work in Progress, and for now, I am printing "df -h" on the runner.

Close: #20251

@potiuk
Copy link
Member

potiuk commented Jan 19, 2022

I think this is a different change ?

@edithturn
Copy link
Contributor Author

@potiuk I am checking this data in the runner:
Screenshot from 2022-01-19 10-58-14

@potiuk
Copy link
Member

potiuk commented Jan 19, 2022

You won't see it because you are not committer :). I will have to push it

@potiuk
Copy link
Member

potiuk commented Jan 19, 2022

You will be able to see it here: #20959

@potiuk
Copy link
Member

potiuk commented Jan 19, 2022

BTW. @edithturn When you create a PR you can create it as draft (not very well visible drop-down next to "create Pull Request" button if you want to do something for test - no need to prefix things with [WIP] . You can also convert it to draft and back any time via "convert to draft" link (or "Ready for Review" button). I will convert it to draft now.

@potiuk potiuk marked this pull request as draft January 19, 2022 16:26
@edithturn
Copy link
Contributor Author

edithturn commented Jan 19, 2022

@potiuk I was wondering how to make it to avoid notifying others, thank you so much! 🙏🏼

@edithturn
Copy link
Contributor Author

edithturn commented Jan 19, 2022

@potiuk I fixed it. I am considering, the mount point:
you can see it here: https://github.com/apache/airflow/runs/4871033753?check_suite_focus=true#step:7:90

# Disk current available partition_usage = psutil.disk_usage('/') disk_available = round(get_size(partition_usage.free))

Also, I rounded the value.

@edithturn edithturn marked this pull request as ready for review January 19, 2022 23:39
@edithturn edithturn force-pushed the check-verify-enough-resources-for-breeze branch from 7ec87aa to cb3f338 Compare January 20, 2022 16:08
@potiuk
Copy link
Member

potiuk commented Jan 20, 2022

FYI @edithturn : I am running it in my PR to check if it will also work for committers: #20959

@edithturn
Copy link
Contributor Author

Thank you so much @potiuk, I also sent the last test, it takes time, especially the one which build the image.

@edithturn
Copy link
Contributor Author

What defines a "committer"?

@potiuk
Copy link
Member

potiuk commented Jan 20, 2022

What defines a "committer"?

This list:

@edithturn
Copy link
Contributor Author

What defines a "committer"?

This list:

I see you have elevated privileges for Github events, right?
Are there things you can see in CI's processes that we can't?

@potiuk
Copy link
Member

potiuk commented Jan 20, 2022

Are there things you can see in CI's processes that we can't?

Nope. It's just where the builds are run. There is no difference in what we see.

@edithturn
Copy link
Contributor Author

I am running it in my PR to check if it will also work for committers: #
Screenshot from 2022-01-20 12-40-54

@potiuk this is the result on your runner. I also checked the one I sent, it finished successfully: https://github.com/apache/airflow/actions/runs/1724358952

let me know what are you thoughts

@potiuk potiuk changed the title [WIP] Re-verify enough resources for Docker Verify enough resources for Docker Jan 20, 2022
@potiuk potiuk merged commit 8ff5fe2 into apache:main Jan 20, 2022
@potiuk
Copy link
Member

potiuk commented Jan 20, 2022

Careful 🎉 :)

@potiuk
Copy link
Member

potiuk commented Jan 20, 2022

🤞

@edithturn
Copy link
Contributor Author

🤞🏼

@edithturn
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Breeze: Verify if there are enough resources avaiilable in Breeze

2 participants