Add extra sync when adding executable flag to installation scripts #20987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
area:production-image
ashb
reviewed
Jan 20, 2022
potiuk
force-pushed
the
fix-aufs-sync-limitations
branch
from
db8bdd4 to
1f34589
Compare
Member
Author
|
Even better now! |
Seems that when AUFS is a backing storage for Docker, changing the script to executable and executing it right after during the build phase might cause an error: 'text file busy' moby/moby#13594 Workaround for that is to add extra `sync` command after changing the executable flag to make sure that the filesystem change has propageted to the underlying AUFS storage. This PR adds the sync and also makes sure that both CI And PROD image use same formatting, executable bits and `&&` between commands rather than `;`. The `&&` is better to separate the commands because it will not continue with execution steps in the same bash command after previous command fails. This caused confusion as to what is the reason for docker build failure. The problem was raised in the apache#20971 discussion.
potiuk
force-pushed
the
fix-aufs-sync-limitations
branch
from
1f34589 to
e8a54de
Compare
ashb
approved these changes
Jan 20, 2022
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Member
Author
|
Images built and verified - looks good. Merging :) |
potiuk
added a commit
that referenced
this pull request
Jan 22, 2022
…20987) Seems that when AUFS is a backing storage for Docker, changing the script to executable and executing it right after during the build phase might cause an error: 'text file busy' moby/moby#13594 Workaround for that is to add extra `sync` command after changing the executable flag to make sure that the filesystem change has propageted to the underlying AUFS storage. This PR adds the sync and also makes sure that both CI And PROD image use same formatting, executable bits and `&&` between commands rather than `;`. The `&&` is better to separate the commands because it will not continue with execution steps in the same bash command after previous command fails. This caused confusion as to what is the reason for docker build failure. The problem was raised in the #20971 discussion. (cherry picked from commit c135581)
jedcunningham
pushed a commit
that referenced
this pull request
Jan 27, 2022
…20987) Seems that when AUFS is a backing storage for Docker, changing the script to executable and executing it right after during the build phase might cause an error: 'text file busy' moby/moby#13594 Workaround for that is to add extra `sync` command after changing the executable flag to make sure that the filesystem change has propageted to the underlying AUFS storage. This PR adds the sync and also makes sure that both CI And PROD image use same formatting, executable bits and `&&` between commands rather than `;`. The `&&` is better to separate the commands because it will not continue with execution steps in the same bash command after previous command fails. This caused confusion as to what is the reason for docker build failure. The problem was raised in the #20971 discussion. (cherry picked from commit c135581)
jedcunningham
added
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that when AUFS is a backing storage for Docker, changing
the script to executable and executing it right after during the
build phase might cause an error: 'text file busy'
moby/moby#13594
Workaround for that is to add extra
synccommand after changingthe executable flag to make sure that the filesystem change has
propageted to the underlying AUFS storage.
This PR adds the sync and also makes sure that both CI And PROD
image use same formatting, executable bits and
&&betweencommands rather than
;. The&&is better to separate thecommands because it will not continue with execution steps in the
same bash command after previous command fails. This caused
confusion as to what is the reason for docker build failure.
The problem was raised in the #20971 discussion.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.