Skip to content

Conversation

@caxefaizan
Copy link
Contributor

@caxefaizan caxefaizan commented Jan 24, 2022

In Volume Mount the name was mismatched from volume names

@boring-cyborg boring-cyborg bot added the provider:cncf-kubernetes Kubernetes (k8s) provider related issues label Jan 24, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 24, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jan 24, 2022
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit 4fb005e into apache:main Jan 24, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 24, 2022

Awesome work, congrats on your first merged pull request!

@jedcunningham jedcunningham added this to the Airflow 2.2.4 milestone Jan 24, 2022
@jedcunningham jedcunningham added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 24, 2022
@caxefaizan caxefaizan deleted the patch-2 branch January 25, 2022 04:54
jedcunningham pushed a commit that referenced this pull request Jan 26, 2022
(cherry picked from commit 4fb005e)
jedcunningham pushed a commit that referenced this pull request Jan 27, 2022
(cherry picked from commit 4fb005e)
jedcunningham pushed a commit that referenced this pull request Jan 28, 2022
(cherry picked from commit 4fb005e)
jedcunningham pushed a commit that referenced this pull request Feb 17, 2022
(cherry picked from commit 4fb005e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge provider:cncf-kubernetes Kubernetes (k8s) provider related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants