Return slack api call response in slack_hook #21107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinYang21
approved these changes
Jan 25, 2022
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
mik-laj
reviewed
Jan 25, 2022
pingzh
force-pushed
the
pz-return-slack-apicall
branch
from
e82cc51 to
976ff0a
Compare
uranusjr
reviewed
Jan 26, 2022
pingzh
force-pushed
the
pz-return-slack-apicall
branch
3 times, most recently
from
dc5bd29 to
dc19b7f
Compare
pingzh
force-pushed
the
pz-return-slack-apicall
branch
from
dc19b7f to
ecd3451
Compare
uranusjr
approved these changes
Jan 27, 2022
potiuk
approved these changes
Jan 27, 2022
This was referenced Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some useful information returned from the slack api call, like
thread_tshttps://api.slack.com/methods/chat.postMessage#arg_thread_tsso returning the response obj to the caller.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.