Add back legacy .piprc customization for pip#21124
Merged
jedcunningham merged 1 commit intoapache:mainfrom Jan 26, 2022
Merged
Conversation
This change brings back backwards compatibility to using .piprc to customize Airflow Image. Some older vrsions of pip used .piprc (even though documentation about is difficult to find now) and we used to support this option. With apache#20445, we changed to use (fully documented) ``pip.conf`` option, however if someone used .piprc before to customize their image, this change would break it. The PR brings back also the .piprc option to the image (even if it is not really clear whether current and future versions of pip will support it.
boring-cyborg
bot
added
area:production-image
Member
Author
|
@jedcunningham - as discussed - we should cherry-pick that change for 2.1.4 to make sure there are no backwards-compaatibility problems. |
jedcunningham
approved these changes
Jan 26, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
jedcunningham
added
the
changelog:skip
jedcunningham
pushed a commit
that referenced
this pull request
Jan 26, 2022
This change brings back backwards compatibility to using .piprc to customize Airflow Image. Some older vrsions of pip used .piprc (even though documentation about is difficult to find now) and we used to support this option. With #20445, we changed to use (fully documented) ``pip.conf`` option, however if someone used .piprc before to customize their image, this change would break it. The PR brings back also the .piprc option to the image (even if it is not really clear whether current and future versions of pip will support it. (cherry picked from commit d5a9edf)
jedcunningham
pushed a commit
that referenced
this pull request
Jan 27, 2022
This change brings back backwards compatibility to using .piprc to customize Airflow Image. Some older vrsions of pip used .piprc (even though documentation about is difficult to find now) and we used to support this option. With #20445, we changed to use (fully documented) ``pip.conf`` option, however if someone used .piprc before to customize their image, this change would break it. The PR brings back also the .piprc option to the image (even if it is not really clear whether current and future versions of pip will support it. (cherry picked from commit d5a9edf)
jedcunningham
pushed a commit
that referenced
this pull request
Jan 28, 2022
This change brings back backwards compatibility to using .piprc to customize Airflow Image. Some older vrsions of pip used .piprc (even though documentation about is difficult to find now) and we used to support this option. With #20445, we changed to use (fully documented) ``pip.conf`` option, however if someone used .piprc before to customize their image, this change would break it. The PR brings back also the .piprc option to the image (even if it is not really clear whether current and future versions of pip will support it. (cherry picked from commit d5a9edf)
jedcunningham
pushed a commit
that referenced
this pull request
Feb 17, 2022
This change brings back backwards compatibility to using .piprc to customize Airflow Image. Some older vrsions of pip used .piprc (even though documentation about is difficult to find now) and we used to support this option. With #20445, we changed to use (fully documented) ``pip.conf`` option, however if someone used .piprc before to customize their image, this change would break it. The PR brings back also the .piprc option to the image (even if it is not really clear whether current and future versions of pip will support it. (cherry picked from commit d5a9edf)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change brings back backwards compatibility to using .piprc
to customize Airflow Image. Some older vrsions of pip used .piprc
(even though documentation about is difficult to find now) and we
used to support this option. With #20445, we changed to use
(fully documented)
pip.confoption, however if someone used.piprc before to customize their image, this change would break it.
The PR brings back also the .piprc option to the image (even if
it is not really clear whether current and future versions of pip
will support it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.