Display better error message when importing providers has errors #21182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
potiuk
force-pushed
the
better-errors-when-importing-providers-has-errors
branch
5 times, most recently
from
fe3751c to
82aac91
Compare
potiuk
force-pushed
the
better-errors-when-importing-providers-has-errors
branch
3 times, most recently
from
902e6d0 to
eb3054f
Compare
potiuk
requested review from
ashb,
jedcunningham,
kaxil and
mik-laj
as code owners
Member
Author
|
Much better errror output:
|
potiuk
force-pushed
the
better-errors-when-importing-providers-has-errors
branch
from
eb3054f to
cb54e76
Compare
potiuk
force-pushed
the
better-errors-when-importing-providers-has-errors
branch
3 times, most recently
from
ed59b16 to
c30dd2a
Compare
Member
Author
|
Right - this is the final version:
I just pushed it error-free so that we can merge it. |
When there are import errors in providers we printed errors in a folded group which lead to poor discovery of those errors. Also with recent changes to Airflow main for upcoming 2.3 version some errors might become more common when developing providers. Specifically the way how to import Context in order to satisfy MyPy and keep Airflow 2.1 compatibility is not obvious. This change introduces helpful guideline to users adding new providers: * moving errors outside of the folded group with imports * adding comment explaining what the errors are about * adding message about backwards compatibility in case errors happen during 2.1.0 backwards-compatibility check * adding explanation and suggest a fix in the common Context impport error
potiuk
force-pushed
the
better-errors-when-importing-providers-has-errors
branch
from
c30dd2a to
797794c
Compare
Member
Author
|
This one will be nice for users who struggle with Airflow 2.1 compatibility for providers :). |
Member
Author
|
cc: @pateash WDYT ? |
Contributor
This looks great. Cheers. |
Member
Author
|
Anyone please :) . This will be a life-saver for those who will be adding features for providers. @turbaszek I think you even requested it once and I thought it was fixed - but this one should be way better (see #13924) |
Member
Author
|
Hello :) :) :) |
Member
Author
|
Just copying the nice image again to drag attention:
Pretty please:
|
ashb
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are import errors in providers we printed errors
in a folded group which lead to poor discovery of those errors.
Also with recent changes to Airflow main for upcoming 2.3 version
some errors might become more common when developing providers.
Specifically the way how to import Context in order to satisfy
MyPy and keep Airflow 2.1 compatibility is not obvious.
This change introduces helpful guideline to users adding new
providers:
errors happen during 2.1.0 backwards-compatibility check
impport error
Just last commit matters!
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.