Fix building documentation for PSRP#21260
Merged
potiuk merged 1 commit intoapache:mainfrom Feb 1, 2022
Merged
Conversation
The PSRP docs building failes in main/PR after merging apache#19806 because the docusmentation needs to be rebuilt one more time because of sequence of building the documentation. In main and new PRs the "apache-airflow" documentation is not build before misrosoft psrp is built, and the psrp docs uses reference to the airlfow "concept" documentation and the link is not existing yet in the inventory for apache-airflow. This results in a race condition where PSRP documentation fails with `toctree contains reference to nonexisting document` The error has not been included in the list of errors that are "eligible for rebuild" and the race condition was triggered. This change adds the error to errors "eligible for rebuild" and makes PSRP documentation build succeed on retry.
jedcunningham
approved these changes
Feb 1, 2022
github-actions
bot
added
the
okay to merge
eladkal
approved these changes
Feb 1, 2022
|
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PSRP docs building fails in main/PR after merging #19806
because the docusmentation needs to be rebuilt one more time
because of sequence of building the documentation. In main and
new PRs the "apache-airflow" documentation is not build
before misrosoft psrp is built, and the psrp docs uses
reference to the airlfow "concept" documentation and the
link is not existing yet in the inventory for apache-airflow.
This results in a race condition where PSRP documentation fails
with
toctree contains reference to nonexisting documentThe error has not been included in the list of errors that
are "eligible for rebuild" and the race condition was triggered.
This change adds the error to errors "eligible for rebuild" and
makes PSRP documentation build succeed on retry.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.