Add and use supports_celery attribute for cli celery command validation #21351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexchen8
requested review from
XD-DENG,
ashb,
dstandish,
jedcunningham and
kaxil
as code owners
alexchen8
force-pushed
the
executor-supports-celery
branch
2 times, most recently
from
4ebe83c to
48636a6
Compare
boring-cyborg
bot
added
area:CLI
provider:cncf-kubernetes
alexchen8
force-pushed
the
executor-supports-celery
branch
3 times, most recently
from
795c70f to
fd4f1bf
Compare
Contributor
Author
|
@ashb Just want to see what's your thought on this as the last modification was from you. |
Contributor
Author
|
Just want to resurface this PR... @potiuk Do you have any thoughts on this? |
alexchen8
force-pushed
the
executor-supports-celery
branch
from
244b1a6 to
8820deb
Compare
potiuk
approved these changes
Feb 19, 2022
Member
|
I will need one more committer's approval though. |
alexchen8
force-pushed
the
executor-supports-celery
branch
from
df12258 to
17ec0d5
Compare
alexchen8
force-pushed
the
executor-supports-celery
branch
from
17ec0d5 to
4e69c85
Compare
Contributor
Author
|
My apologies, just noticed that my initial commit was done using company email address. Had to rebase/force push to use personal email. |
Member
|
Anyone else? |
Contributor
Author
|
Bumping this PR for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing existing celery subclass check in celery cli validation with a new attribute to Celery based executors.
Also moved celery module check a level higher. IMO, it is worth checking even if the user is using built-in Celery or C-K executors.
The reason behind this change is to allow any custom executor to utilize built-in airflow celery executor/worker. There are some cases that doesn't make sense to subclass the existing Celery / C-K executors (for example a similar implementation of C-K executor that has some other executors for routing, but not Kubernetes").
This change should be backward compatible, assuming subclasses of C/C-K in the wild does not have
supports_celeryattribute defined for other use.