-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Revert "Simplify fab has access lookup (#19294)" #21464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Just trying to see if reverting this one helps with the docker-compose tests |
a1fcddb to
96698fa
Compare
|
Hey @ashb @jhtimmins -> as explained in #21407 reverting this one will fix the flakly docker-compose" tests most likely (and actually the flaky tests had shown that there is a real issue (root cause of the #21407 ) |
This reverts commit 3e98280.
96698fa to
8768887
Compare
|
Seems like I got a repetitive success with that one so this is quite likely the culprit of the flaky tests I will re-run it with "public runners" now but I think we will need to revert it and re-do the "simplify" |
ashb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unblocking CI.
Do we know how to reliably trigger the bug so we can test it's fixed when we reintroduce this changeset?
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Actually .... this does not seem like it ... The last run when I was using https://github.com/apache/airflow/runs/5128289741?check_suite_focus=true#step:7:2081 |
|
There were few other problems there as well. |
This reverts commit 3e98280.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.