Skip to content

Conversation

@bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Feb 9, 2022

Before, when a user hovered over a task instance, we only highlighted the row to show what task it belonged to. This PR also highlights the column to show the dag run. This now creates a "crosshair" to let a user more easily which task instance they are hovering on.

Screen Shot 2022-02-09 at 3 16 01 PM

Before After
Feb-09-2022 13-12-14 Feb-09-2022 13-02-35

@bbovenzi bbovenzi added the AIP-38 Modern Web Application label Feb 9, 2022
@bbovenzi bbovenzi added this to the Airflow 2.3.0 milestone Feb 9, 2022
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Feb 9, 2022
Copy link
Contributor

@ryanahamilton ryanahamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the yarn.lock update be excluded from this PR?

@bbovenzi
Copy link
Contributor Author

Can the yarn.lock update be excluded from this PR?

Actually, I forgot that yarn upgrade doesn't update package.json by default. Fixed.

Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Feb 15, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@bbovenzi bbovenzi merged commit f1db452 into apache:main Feb 15, 2022
@bbovenzi bbovenzi deleted the tree-crosshairs branch February 15, 2022 16:00
@jedcunningham jedcunningham added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AIP-38 Modern Web Application area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants