Pass Trino hook params to DbApiHook #21479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @Skuratovskyi |
kazanzhy
force-pushed
the
pass_params_from_trino_to_dbapi_21125
branch
from
eb73ad5 to
070f90b
Compare
Skuratovskyi
approved these changes
Feb 14, 2022
eladkal
approved these changes
Feb 15, 2022
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
eladkal
reviewed
Feb 15, 2022
| def run(self, hql, autocommit: bool = False, parameters: Optional[dict] = None, handler=None) -> None: | ||
| def run( | ||
| self, | ||
| hql: str, |
Contributor
There was a problem hiding this comment.
We really should get rid of the hql across the whole class
Trino uses sql. #21597
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passed TrinoHook params to DbApiHook methods:
insert_rows,runAdded types for TrinoHook methods:
get_records,get_pandas_dfAdded test for
TrinoHook.run()closes: #21125