Rename operator mapping map() to apply()#21754
Merged
uranusjr merged 1 commit intoapache:mainfrom Feb 24, 2022
Merged
Conversation
ashb
approved these changes
Feb 23, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
uranusjr
force-pushed
the
map-rename-apply
branch
from
82c87b6 to
6f3a750
Compare
dstandish
approved these changes
Feb 24, 2022
Contributor
dstandish
left a comment
dstandish
left a comment
There was a problem hiding this comment.
i think i caught one small thing with the len comparison but otherwise looks good
uranusjr
force-pushed
the
map-rename-apply
branch
2 times, most recently
from
5dec1b5 to
06661f8
Compare
uranusjr
force-pushed
the
map-rename-apply
branch
from
06661f8 to
989d581
Compare
rustikk
pushed a commit
to rustikk/airflow
that referenced
this pull request
Feb 25, 2022
jedcunningham
added
the
changelog:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the design discussion, we’re going to use
map()for something else that matches more closely to the FPmapconcept.Do we also want to rename
mapped_kwargsto something else? (to what?)