Make sure emphasis in UPDATING in .md is consistent#21804
Conversation
There is a new rule in markdownlint which has been violated in main when new version of pre-commits is installed introduced in the apache#21734
|
Hmm I've already used underscore for emphasis/italics |
|
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
|
It's just it was inconsistently used in this file - some emphasis used _ and some * :) (we had both in the file). |
|
Did we mean our version of markdownlint to change without explicit action? |
Nope. I was just looking at it why it did not install for me (but I wanted to quickly fix it first) It is installed automatically by pre-commit - we have: And markdownlint-cli - drags markdownlint alongside: https://www.npmjs.com/package/markdownlint. Markdownlint was released on Jan 15 but if you had pre-commit installed locally, it did not upgrade to latest version. Apparenttly when you already had markdownlint-cli (thus markdownlint) installed by pre-commit, it would not trigger automated update to latest version. I am fixing this now. |
|
This is really strange - I even can't reinstall markdownlint from scratch now (TypeError: files.flat is not a function).... |
There is a new rule in markdownlint which has been violated in main when new version of pre-commits is installed introduced in the apache#21734
There is a new rule in markdownlint which has been violated in
main when new version of pre-commits is installed introduced in
the #21734
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.