Skip to content

feat: add an operator to run a transfer job#22022

Closed
abhinavraj23 wants to merge 3 commits intoapache:mainfrom
abhinavraj23:feature/run-transfer-job-operator
Closed

feat: add an operator to run a transfer job#22022
abhinavraj23 wants to merge 3 commits intoapache:mainfrom
abhinavraj23:feature/run-transfer-job-operator

Conversation

@abhinavraj23
Copy link

Add an operator in google storage transfer service to directly run a pre-configured transfer job. The storage transfer service provides the API for this use case, here the link to the API. Corresponding to this API the cloud_transfer_service hook has been changed and an operator has been added.

closes: #22019


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@abhinavraj23 abhinavraj23 requested a review from turbaszek as a code owner March 6, 2022 07:11
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Mar 6, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 6, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add fallback to default_project_id from connection? To do it, you should use @GoogleBaseHook.fallback_to_default_project_id decorator.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @mik-laj, have made the change

@abhinavraj23 abhinavraj23 requested a review from mik-laj March 7, 2022 09:55
@potiuk
Copy link
Member

potiuk commented Mar 7, 2022

You also need to add some tests (and fix static check and test

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Apr 22, 2022
@github-actions github-actions bot closed this Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Google cloud dataproc: Add an operator to run a serverless spark in dataproc

3 participants

Comments