Merged
Conversation
potiuk
force-pushed
the
add-cgroupspy-to-vendor
branch
from
6631420 to
9ba74df
Compare
potiuk
force-pushed
the
add-cgroupspy-to-vendor
branch
2 times, most recently
from
a96efbe to
f1218e1
Compare
potiuk
requested review from
ashb,
dstandish,
ephraimbuddy,
jedcunningham,
kaxil,
mik-laj and
turbaszek
This was referenced Mar 12, 2022
potiuk
force-pushed
the
add-cgroupspy-to-vendor
branch
from
f1218e1 to
aca5385
Compare
uranusjr
approved these changes
Mar 13, 2022
Member
uranusjr
left a comment
uranusjr
left a comment
There was a problem hiding this comment.
Need to merge the vendor structure PR first.
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
force-pushed
the
add-cgroupspy-to-vendor
branch
from
aca5385 to
3d86b7e
Compare
potiuk
force-pushed
the
add-cgroupspy-to-vendor
branch
2 times, most recently
from
776ba16 to
eff5643
Compare
We need to vendor in cgroupspy library in order to make Airflow compatible with Python 3.10 (see apache#22050) so this is the right time to make our vendoring process more organized. I based in parts on the readme described by `bleach` package.
This is just importing existing cgroupspy library without code modifications. In the next step we will modify the cgroupspy code to work from the new location, then we will fix it to implement Python 3.10 compatibility and finally we will change airflow to use the vendored package instead of the original package. This is part of the effort needed to implement Python 3.10 compatibility: apache#22050
potiuk
force-pushed
the
add-cgroupspy-to-vendor
branch
from
eff5643 to
7892ac9
Compare
Member
Author
|
Just random error. Parent PR already merged so this one can be merged too. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Apr 4, 2022
The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible. We can remove vendoring done as of apache#22209 apache#22208 apache#2207 apache#22206 Discussion and links: * cloudsigma/cgroupspy#14
Merged
potiuk
added a commit
that referenced
this pull request
Apr 4, 2022
The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible. We can remove vendoring done as of #22209 #22208 #2207 #22206 Discussion and links: * cloudsigma/cgroupspy#14
jedcunningham
added
the
changelog:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just importing existing cgroupspy library without
code modifications. In the next step we will modify the cgroupspy
code to work from the new location, then we will fix it to
implement Python 3.10 compatibility and finally we will change
airflow to use the vendored package instead of the original
package.
This is part of the effort needed to implement Python 3.10
compatibility: #22050
This PR is based on #22204 so only look at the last commit.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.