[AIRFLOW-1091] Add script that can compare jira target against merges by bolkedebruin · Pull Request #2231 · apache/airflow

bolkedebruin · 2017-04-08T19:22:12Z

Dear Airflow maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-1091

Description

Here are some details about my PR, including screenshots of any UI changes:

When working towards a release it is convenient to be able to compare
what has been merged into the current branch and what has not.

Tests

My PR adds the following unit tests OR does not need testing for this extremely good reason:

For development only

Commits

My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"

@criccomini enjoy! (works only in the current branch at the moment)

codecov-io · 2017-04-08T19:53:09Z

Codecov Report

Merging #2231 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2231      +/-   ##
==========================================
+ Coverage   68.73%   68.77%   +0.03%     
==========================================
  Files         142      142              
  Lines       10926    10926              
==========================================
+ Hits         7510     7514       +4     
+ Misses       3416     3412       -4

Impacted Files	Coverage Δ
airflow/jobs.py	`73.28% <0%> (+0.4%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d0c2f6...98424da. Read the comment docs.

criccomini · 2017-04-10T15:36:11Z

I had to pip install GitPython to make this work. Should this be added to the checks at the top of the script? I grepped the Airflow code, and didn't find GitPython anywhere in it (setup.py, etc).

criccomini · 2017-04-10T15:36:35Z

This is awesome. Ran the script, and it appears to work as expected!

$ ./airflow-jira compare 1.8.1
ISSUE ID          |TYPE        ||PRIORITY  ||STATUS    |DESCRIPTION                                       |MERGED|PR    |COMMIT                                  
AIRFLOW-1062      |Bug         ||Major     ||Resolved  |DagRun#find returns wrong result if external_trigg|1     |#2210 |010b80aa8b417091705556a07d5970fe0cc4efb2
AIRFLOW-1058      |Improvement ||Major     ||Resolved  |Improvements for SparkSubmitOperator              |0     |-     |-                                       
AIRFLOW-1055      |Bug         ||Blocker   ||Open      |airflow/jobs.py:create_dag_run() exception for @on|0     |-     |-                                       
AIRFLOW-1054      |Bug         ||Minor     ||Closed    |Fix broken import on test_dag                     |1     |#2201 |68b1c982e048878ec9dd658072c147e4341bf2c2
AIRFLOW-1050      |Bug         ||Blocker   ||Resolved  |Retries ignored - regression                      |0     |-     |-                                       
AIRFLOW-1035      |Bug         ||Major     ||Resolved  |Exponential backoff retry logic should use 2 as ba|0     |-     |-                                       
AIRFLOW-1033      |Bug         ||Blocker   ||Resolved  |TypeError: can't compare datetime.datetime to None|0     |-     |-                                       
AIRFLOW-1030      |Bug         ||Major     ||Resolved  |HttpHook error when creating HttpSensor           |0     |-     |-                                       
AIRFLOW-1019      |Improvement ||Critical  ||Open      |active_dagruns shouldn't include paused DAGs      |0     |-     |-                                       
AIRFLOW-1018      |Bug         ||Critical  ||Open      |Scheduler DAG processes can not log to stdout     |0     |-     |-                                       
AIRFLOW-1017      |Bug         ||Critical  ||Resolved  |get_task_instance should return None instead of th|1     |#2178 |2106ff57056d08436d8aab87ac5601d9f554935a
AIRFLOW-1015      |Improvement ||Minor     ||Open      |TreeView displayed over task instances            |0     |-     |-                                       
AIRFLOW-1014      |Bug         ||Major     ||Closed    |depends_on_past code assumes previous dag_run had |0     |-     |-                                       
AIRFLOW-1013      |Bug         ||Critical  ||Open      |airflow/jobs.py:manage_slas() exception for @once |0     |-     |-                                       
AIRFLOW-1011      |Bug         ||Blocker   ||Resolved  |Fix bug in BackfillJob._execute() for SubDAGs     |1     |#2179 |2bebeaf9554d35710de6eb1b4006157e105ac79b
AIRFLOW-1004      |Bug         ||Major     ||Resolved  |`airflow webserver -D` runs in foreground         |0     |-     |-                                       
AIRFLOW-1001      |Bug         ||Blocker   ||Closed    |Landing Time shows "unsupported operand type(s) fo|0     |-     |-                                       
AIRFLOW-1000      |Task        ||Blocker   ||Open      |Rebrand to Apache Airflow instead of Airflow      |0     |-     |-                                       
AIRFLOW-993       |Bug         ||Minor     ||Open      |Dags should modify the start date and end date of |0     |-     |-                                       
AIRFLOW-989       |Bug         ||Critical  ||Resolved  |Clear Task Regression                             |1     |#2154 |15600e42c805b222d6147b60376b56c8e708dcde
AIRFLOW-976       |Bug         ||Major     ||Open      |Mark success running task causes it to fail       |0     |-     |-                                       
AIRFLOW-974       |Bug         ||Major     ||Resolved  |airflow.util.file mkdir has a race condition      |1     |#2147 |3b37cfa1f2642ff90908a3af0a5674637c9518ee
AIRFLOW-945       |Bug         ||Major     ||Open      |Revert psycopg2 workaround when psycopg2 2.7.1 is |0     |-     |-                                       
AIRFLOW-906       |Improvement ||Minor     ||Resolved  |Update Code icon from lightning bolt to file      |1     |#2104 |46ca569a37513f3d13c529786f65c7e443c9837e
AIRFLOW-858       |Improvement ||Minor     ||Resolved  |Configurable database name for DB operators       |1     |#2063 |5eb33358f62a13192e537296becc315476112afb
AIRFLOW-853       |Bug         ||Major     ||Resolved  |ssh_execute_operator.py stdout decode default to A|1     |#2060 |101700853896fdb90cda4267b5310e6c8811f4f0
AIRFLOW-832       |Bug         ||Major     ||Resolved  |Fix debug server                                  |1     |#2051 |eb12f0164fbeedbe2701744c213cc90e6fc805f5
AIRFLOW-817       |Bug         ||Major     ||Resolved  |Trigger dag fails when using CLI + API            |1     |#2034 |2b13109ff01ee1534d611665d974667a06787cb2
AIRFLOW-816       |Bug         ||Major     ||Resolved  |Make sure to pull nvd3 from local resources       |1     |#2035 |1accb54ff561b8d745277308447dd6f9d3e9f8d5
AIRFLOW-815       |Improvement ||Minor     ||Resolved  |Add previous/next execution dates to available def|1     |#2033 |a67e4390d2217dd0fdc3429e943cdc6c552fac73
AIRFLOW-813       |Bug         ||Major     ||Resolved  |Fix unterminated unit tests in tests.job (tests/jo|1     |#2028 |cf6d50c0e3d59ec9155be445c127c90a05cc90a2
AIRFLOW-812       |Bug         ||Major     ||Resolved  |Scheduler job terminates when there is no dag file|1     |#2027 |f8d8ddac08dbec90b240a6b8670be9bd650dfb3b
AIRFLOW-806       |Improvement ||Trivial   ||Resolved  |UI should properly ignore DAG doc when it is None |1     |#2020 |6060f653a1720a6255893ec7067d7e6eda1bffaf
AIRFLOW-794       |Improvement ||Minor     ||Resolved  |Consistent access to DAGS_FOLDER and SQL_ALCHEMY_C|1     |#2013 |2592024230a25820d368ecc3bd43fbf7b52e46d9
AIRFLOW-788       |Bug         ||Major     ||Open      |Context unexpectedly added to hive conf           |0     |-     |-                                       
AIRFLOW-785       |Bug         ||Major     ||Resolved  |ImportError if cgroupspy is not installed         |1     |#na   |1a801cc3b4e5263278a780df59f30f72c21597dc
AIRFLOW-784       |Bug         ||Major     ||Resolved  |Cannot install with funcsigs > 1.0.0              |1     |#na   |cce6ffcf079e1385de3611329f2817ba6f34fa66
AIRFLOW-780       |Bug         ||Critical  ||Resolved  |The UI no longer shows broken DAGs                |1     |#2018 |67cbb966410226c1489bb730af3af45330fc51b9
AIRFLOW-777       |Bug         ||Major     ||Resolved  |dag_is_running is initlialized to True instead of |1     |#na   |2d2d6270ad6bf6052c3efe90100740d3470c0cd1
AIRFLOW-719       |Sub-task    ||Blocker   ||Closed    |Skipped operations make DAG finish prematurely    |1     |#2125 |4077c6de297566a4c598065867a9a27324ae6eb1
AIRFLOW-694       |Bug         ||Minor     ||Resolved  |Empty env vars do not overwrite non-empty config v|1     |#2044 |5405f5f83c6e20fff2dc209cd4be3d1d5ea85140
AIRFLOW-139       |Bug         ||Major     ||Resolved  |Executing VACUUM with PostgresOperator            |1     |#1821 |ac9167f37b586f9ece381763b91a0ee25d736f38
AIRFLOW-111       |Sub-task    ||Major     ||Resolved  |DAG concurrency is not honored                    |0     |-     |-                                       
AIRFLOW-88        |Improvement ||Minor     ||Resolved  |Improve clarity Travis CI reports                 |1     |#2049 |3b1e81ac9e8e97b6d2a4c3217df81db9ddbd0900

criccomini · 2017-04-10T15:36:45Z

Couple of nits, but other than that, LGTM

criccomini · 2017-04-10T15:38:35Z

Make sure to update the release wiki, too. :)

criccomini · 2017-04-10T15:35:42Z

dev/airflow-jira

airflow-jira

criccomini · 2017-04-10T15:35:48Z

dev/airflow-jira

airflow-jira

When working towards a release it is convenient to be able to compare what has been merged into the current branch and what has not.

When working towards a release it is convenient to be able to compare what has been merged into the current branch and what has not. Closes apache#2231 from bolkedebruin/AIRFLOW-1091

criccomini reviewed Apr 12, 2017

View reviewed changes

bolkedebruin force-pushed the AIRFLOW-1091 branch from ebf30d3 to 91da8bc Compare April 17, 2017 09:21

[AIRFLOW-1091] Add script that can compare jira target against merges

98424da

When working towards a release it is convenient to be able to compare what has been merged into the current branch and what has not.

bolkedebruin force-pushed the AIRFLOW-1091 branch from 91da8bc to 98424da Compare April 17, 2017 09:24

asfgit closed this in bfae428 Apr 17, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AIRFLOW-1091] Add script that can compare jira target against merges#2231

[AIRFLOW-1091] Add script that can compare jira target against merges#2231
bolkedebruin wants to merge 1 commit intoapache:masterfrom
bolkedebruin:AIRFLOW-1091

bolkedebruin commented Apr 8, 2017 •

edited

Loading

Uh oh!

codecov-io commented Apr 8, 2017 •

edited

Loading

Uh oh!

criccomini commented Apr 10, 2017

Uh oh!

criccomini commented Apr 10, 2017

Uh oh!

criccomini commented Apr 10, 2017

Uh oh!

criccomini commented Apr 10, 2017

Uh oh!

criccomini Apr 10, 2017

Uh oh!

criccomini Apr 10, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

bolkedebruin commented Apr 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

JIRA

Description

Tests

Commits

Uh oh!

codecov-io commented Apr 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

criccomini commented Apr 10, 2017

Uh oh!

criccomini commented Apr 10, 2017

Uh oh!

criccomini commented Apr 10, 2017

Uh oh!

criccomini commented Apr 10, 2017

Uh oh!

criccomini Apr 10, 2017

Choose a reason for hiding this comment

Uh oh!

criccomini Apr 10, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bolkedebruin commented Apr 8, 2017 •

edited

Loading

codecov-io commented Apr 8, 2017 •

edited

Loading