removed unnecessary dependence on bcrypt #22498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Need to move the import to satisfy isort. |
potiuk
approved these changes
Mar 24, 2022
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Nice. but yeah - run 'pre-commit' and it will fix it for you automatically.
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
MatrixManAtYrService
force-pushed
the
nobcrypt
branch
from
79fd8a3 to
c623a91
Compare
jedcunningham
approved these changes
Mar 24, 2022
Member
jedcunningham
left a comment
jedcunningham
left a comment
There was a problem hiding this comment.
Can you resolve the conflict when you get the chance?
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
added
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working in a fresh venv and running
airflow db resetI was getting the error:But
from bcrypt import warningsis the same asimport warnings, so this change removes the need to install bcrypt.