Skip to content

If k8s is not installed, add if condition to exclude DAG(local_kubernetes_executor)#22556

Merged
potiuk merged 9 commits intoapache:mainfrom
subkanthi:fix_local_k8s_executor_dag_example
Mar 31, 2022
Merged

If k8s is not installed, add if condition to exclude DAG(local_kubernetes_executor)#22556
potiuk merged 9 commits intoapache:mainfrom
subkanthi:fix_local_k8s_executor_dag_example

Conversation

@subkanthi
Copy link
Contributor

Just like the example_kubernetes_executor.py, add if k8s so that the DAG does not throw an error.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@subkanthi subkanthi changed the title If k8s is not installed, add if condition to exclude DAG If k8s is not installed, add if condition to exclude DAG(local_kubernetes_executor) Mar 27, 2022
@potiuk
Copy link
Member

potiuk commented Mar 27, 2022

Static checks @subkanthi :)

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 27, 2022
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk
Copy link
Member

potiuk commented Mar 29, 2022

Still some checks failing :) ( I think rebasing will fix the click one but there are some blank lines)

@potiuk potiuk merged commit 27d72d7 into apache:main Mar 31, 2022
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants