Fix StatsD casing and helm chart StatsD comments #22610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedcunningham
requested review from
dstandish,
kaxil,
mik-laj and
potiuk
as code owners
jedcunningham
added
the
changelog:skip
dstandish
approved these changes
Mar 31, 2022
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
approved these changes
Mar 31, 2022
kaxil
approved these changes
Mar 31, 2022
jedcunningham
force-pushed
the
statsd_docs_cleanup
branch
from
329ad5c to
1073136
Compare
jedcunningham
force-pushed
the
statsd_docs_cleanup
branch
from
1073136 to
66ba386
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This snowballed a bit, but this fixes the wording on a helm chart StatsD param to indicate it uses the local
uidinstead of the global securitycontext and then a bunch of StatsD casing fixes.