Skip to content

Only hide rendered button for mapped summaries#22633

Merged
bbovenzi merged 1 commit intomainfrom
Fix-rendered-btn-for-mapped-instances
Mar 31, 2022
Merged

Only hide rendered button for mapped summaries#22633
bbovenzi merged 1 commit intomainfrom
Fix-rendered-btn-for-mapped-instances

Conversation

@bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Mar 30, 2022

With #22396 and #22578. Rendered template links should now work for individual mapped task instances. Now, we will only hide them when the modal is showing a summary of all mapped instances.

Screen Shot 2022-03-30 at 3 07 38 PM


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Mar 30, 2022
@bbovenzi bbovenzi requested a review from uranusjr March 30, 2022 19:07
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 31, 2022
@bbovenzi bbovenzi merged commit 730b426 into main Mar 31, 2022
@bbovenzi bbovenzi deleted the Fix-rendered-btn-for-mapped-instances branch March 31, 2022 13:46
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants