Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Mar 31, 2022

Moves group permission cleanup to build command in new Breeze2.

Seems that we should fix group permissions in all build commands.
That will shave extra few minutes on most builds where they
modify sources. Also the output from the build will be a bit
cleaner by removing come of the console outputs.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Moves group permission cleanup to build command in new Breeze2.

Seems that we should fix group permissions in all build commands.
That will shave extra few minutes on most builds where they
modify sources. Also the output from the build will be a bit
cleaner by removing come of the console outputs.
@potiuk potiuk force-pushed the improve-output-of-commands branch from f14462d to b83028c Compare March 31, 2022 16:16
@potiuk
Copy link
Member Author

potiuk commented Mar 31, 2022

@dstandish - few more minutes saved in some cases with this one :)

@potiuk potiuk requested a review from eladkal March 31, 2022 16:17
@potiuk
Copy link
Member Author

potiuk commented Mar 31, 2022

cc: @Bowrna @edithturn - seems that I am ready to start replacing the old Breeze code with this one :). Watch this space.

@potiuk potiuk requested review from ephraimbuddy and mik-laj March 31, 2022 16:33
@potiuk
Copy link
Member Author

potiuk commented Mar 31, 2022

2 minutes per build saved with it :)

@edithturn
Copy link
Contributor

@potiuk this is impressive 💪🏼 , If I want to test this, should I install Breeze, right?

@potiuk
Copy link
Member Author

potiuk commented Mar 31, 2022

@potiuk this is impressive 💪🏼 , If I want to test this, should I install Breeze, right?

Yep.

@edithturn
Copy link
Contributor

cc: @Bowrna @edithturn - seems that I am ready to start replacing the old Breeze code with this one :). Watch this space.

what more do you need @potiuk, could I help with the test?

@potiuk
Copy link
Member Author

potiuk commented Mar 31, 2022

Naaa. I tested it :)

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 31, 2022
@github-actions
Copy link

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit 89a4c4d into apache:main Mar 31, 2022
@potiuk potiuk deleted the improve-output-of-commands branch March 31, 2022 20:54
@potiuk potiuk restored the improve-output-of-commands branch April 26, 2022 20:47
@potiuk potiuk deleted the improve-output-of-commands branch July 29, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants