-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix file permissions in all build commands #22656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Moves group permission cleanup to build command in new Breeze2. Seems that we should fix group permissions in all build commands. That will shave extra few minutes on most builds where they modify sources. Also the output from the build will be a bit cleaner by removing come of the console outputs.
f14462d to
b83028c
Compare
|
@dstandish - few more minutes saved in some cases with this one :) |
|
cc: @Bowrna @edithturn - seems that I am ready to start replacing the old Breeze code with this one :). Watch this space. |
|
2 minutes per build saved with it :) |
|
@potiuk this is impressive 💪🏼 , If I want to test this, should I install Breeze, right? |
Yep. |
what more do you need @potiuk, could I help with the test? |
|
Naaa. I tested it :) |
|
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Moves group permission cleanup to build command in new Breeze2.
Seems that we should fix group permissions in all build commands.
That will shave extra few minutes on most builds where they
modify sources. Also the output from the build will be a bit
cleaner by removing come of the console outputs.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.