Skip to content

Fix state and try number for failed mapped tasks#22757

Merged
ashb merged 1 commit intoapache:mainfrom
astronomer:fix-try-count-ui
Apr 5, 2022
Merged

Fix state and try number for failed mapped tasks#22757
ashb merged 1 commit intoapache:mainfrom
astronomer:fix-try-count-ui

Conversation

@ashb
Copy link
Member

@ashb ashb commented Apr 5, 2022

Without this change the details drawer thinks there are two attempts
rather than one for failed tasks, and a mapped task in UPSTREAM_FAILED
has no_status rather than upstream_failed.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Without this change the details drawer thinks there are two attempts
rather than one for failed tasks, and a mapped task in UPSTREAM_FAILED
has no_status rather than upstream_failed.
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Apr 5, 2022
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Apr 5, 2022
@github-actions
Copy link

github-actions bot commented Apr 5, 2022

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@ashb ashb merged commit a1fd82f into apache:main Apr 5, 2022
@ashb ashb deleted the fix-try-count-ui branch April 5, 2022 18:11
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 8, 2022
@jedcunningham jedcunningham added this to the Airflow 2.3.0 milestone Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dynamic-task-mapping AIP-42 area:webserver Webserver related Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments