Skip to content

Better handle Grid auto-refresh errors#22840

Merged
bbovenzi merged 2 commits intomainfrom
handle-grid-autorefresh-errors
Apr 8, 2022
Merged

Better handle Grid auto-refresh errors#22840
bbovenzi merged 2 commits intomainfrom
handle-grid-autorefresh-errors

Conversation

@bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Apr 7, 2022

If there was an error during autorefresh in Grid view. The page would crash because we weren't handling the error well. axios handles errors better than fetch so I swapped that in and added a toast message to communicate to the user what failed.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Apr 7, 2022
Copy link
Contributor

@ryanahamilton ryanahamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Apr 7, 2022
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@bbovenzi bbovenzi merged commit 85da728 into main Apr 8, 2022
@bbovenzi bbovenzi deleted the handle-grid-autorefresh-errors branch April 8, 2022 15:33
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 10, 2022
@bbovenzi bbovenzi added this to the Airflow 2.3.0 milestone Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants