Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Apr 14, 2022

The new Breeze needs to be installed via pipx in CI - except when
it is unit-tested. Also it needs to be added to PATH.

This change adds a very small script that is used in all places
where Breeze needs to be installed.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk potiuk requested review from ashb, kaxil and mik-laj as code owners April 14, 2022 20:43
@potiuk potiuk force-pushed the properly-install-breeze-in-ci branch 2 times, most recently from ae10782 to 6cac11a Compare April 14, 2022 20:51
@potiuk potiuk requested a review from uranusjr April 14, 2022 20:52
@potiuk potiuk force-pushed the properly-install-breeze-in-ci branch from 6cac11a to 3951922 Compare April 14, 2022 22:11
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Apr 15, 2022
The new Breeze needs to be installed via pipx in CI - except when
it is unit-tested. Also it needs to be added to PATH.

This change adds a very small script that is used in all places
where Breeze needs to be installed.
@potiuk potiuk force-pushed the properly-install-breeze-in-ci branch from 3951922 to d5c2e71 Compare April 15, 2022 09:38
@potiuk
Copy link
Member Author

potiuk commented Apr 15, 2022

Just a random failure. Merging

@potiuk potiuk merged commit c929544 into apache:main Apr 15, 2022
@potiuk potiuk deleted the properly-install-breeze-in-ci branch April 15, 2022 10:19
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 26, 2022
@potiuk potiuk restored the properly-install-breeze-in-ci branch April 26, 2022 20:46
@potiuk potiuk deleted the properly-install-breeze-in-ci branch July 29, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants