Skip to content

Revert disabling run task button#23038

Merged
bbovenzi merged 2 commits intomainfrom
fix-disabled-run-btn
Apr 18, 2022
Merged

Revert disabling run task button#23038
bbovenzi merged 2 commits intomainfrom
fix-disabled-run-btn

Conversation

@bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Apr 15, 2022

I messed up and forgot that the variable k8s_or_k8scelery_executor that we used to disable/enable the Run task button does not actually check for CeleryExecutor. This PR reverts that change and goes back to relying on the webserver to return an error instead of preemptively disabling the button.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Apr 15, 2022
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Apr 15, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@bbovenzi bbovenzi merged commit 10c9cb5 into main Apr 18, 2022
@bbovenzi bbovenzi deleted the fix-disabled-run-btn branch April 18, 2022 21:32
@jedcunningham jedcunningham added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments