Skip to content

Conversation

@kianelbo
Copy link
Contributor


closes: #22810
Use JiraHook instead of JiraOperator in Jira sensors to prevent duplicating task_id

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg
Copy link

boring-cyborg bot commented Apr 15, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming tests pass

@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Apr 16, 2022
@potiuk potiuk merged commit bf10545 into apache:main Apr 25, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 25, 2022

Awesome work, congrats on your first merged pull request!

@kianelbo kianelbo deleted the fix-jira-sensor branch April 25, 2022 15:07
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 26, 2022
@kostiantyn-lab
Copy link

I opened a PR according to what @potiuk explained. This is my first ever contribution and I would really appreciate it if you take a look at it and give your feedbacks.

@kianelbo I've found error in your patch

  File "/usr/local/lib/python3.7/site-packages/airflow/sensors/base.py", line 234, in execute
    while not self.poke(context):
  File "/usr/local/airflow/.local/lib/python3.7/site-packages/airflow_contrib/sensors/jira.py", line 110, in poke
    return JiraSensor.poke(self, context=context)
  File "/usr/local/airflow/.local/lib/python3.7/site-packages/airflow/providers/jira/sensors/jira.py", line 64, in poke
    return self.result_processor(context, jira_result)
TypeError: issue_field_checker() takes 2 positional arguments but 3 were given

I see two ways to fix it

  1. Add context: Dict as parameter to def issue_field_checker(self, issue: Issue) -> Optional[bool]
  2. Remove context parameter from the return self.result_processor(context, jira_result)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JiraTicketSensor duplicates TaskId

5 participants