Ensure TaskMap only checks "relevant" dependencies#23053
Merged
ashb merged 2 commits intoApr 19, 2022
Conversation
boring-cyborg
Bot
added
the
area:Scheduler
uranusjr
force-pushed
the
task-dependency-only-check-relevant
branch
from
a52034e to
69d53b7
Compare
uranusjr
changed the title
uranusjr
force-pushed
the
task-dependency-only-check-relevant
branch
from
69d53b7 to
ce7f207
Compare
This comment was marked as outdated.
This comment was marked as outdated.
uranusjr
force-pushed
the
task-dependency-only-check-relevant
branch
3 times, most recently
from
4546adb to
6bb09ab
Compare
ashb
approved these changes
Apr 19, 2022
Member
ashb
left a comment
ashb
left a comment
There was a problem hiding this comment.
Only nit is that maybe we don't need iter_ in the function name?
github-actions
Bot
added
the
full tests needed
Contributor
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
When looking for "mapped dependants" of a task, we only want a task if it not only is a direct downstream of the task, but also it actually "uses" the task's pushed XCom for task mapping. So we need to peek into the mapped downstream task's expansion kwargs, and only count it as a mapped dependant if the upstream is referenced there.
ashb
force-pushed
the
task-dependency-only-check-relevant
branch
from
6bb09ab to
0194859
Compare
jedcunningham
added
the
changelog:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When looking for "mapped dependants" of a task, we only want a task if it not only is a direct downstream of the task, but also it actually "uses" the task's pushed XCom for task mapping. So we need to peek into the mapped downstream task's expansion kwargs, and only count it as a mapped dependant if the upstream is referenced there.
Fix #23018.