Skip to content

Ensure that DAG calendar view creates the right kind of DateTime objects#23255

Merged
ashb merged 1 commit intoapache:mainfrom
astronomer:fix-timezone-object-dag-calendar
Apr 26, 2022
Merged

Ensure that DAG calendar view creates the right kind of DateTime objects#23255
ashb merged 1 commit intoapache:mainfrom
astronomer:fix-timezone-object-dag-calendar

Conversation

@ashb
Copy link
Member

@ashb ashb commented Apr 26, 2022

This view has entirely too much logic in it, and it all needs to be
moved somewhere else.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

This view has entirely too much logic in it, and it all needs to be
moved somewhere else.
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Apr 26, 2022
@ashb ashb requested a review from ephraimbuddy April 26, 2022 13:52
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Apr 26, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@ashb ashb added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 26, 2022
@ashb ashb merged commit 511ea70 into apache:main Apr 26, 2022
@ashb ashb deleted the fix-timezone-object-dag-calendar branch April 26, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webserver Webserver related Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants