[AIRFLOW-654] Add SSL Config Option for CeleryExecutor w/ RabbitMQ#2333
Closed
forsberg wants to merge 1 commit intoapache:masterfrom
Closed
[AIRFLOW-654] Add SSL Config Option for CeleryExecutor w/ RabbitMQ#2333forsberg wants to merge 1 commit intoapache:masterfrom
forsberg wants to merge 1 commit intoapache:masterfrom
Conversation
- Add BROKER_USE_SSL config to give option to send AMQP messages over SSL - Can be set using usual airflow options (e.g. airflow.cfg, env vars, etc.)
|
@forsberg, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bolkedebruin, @mistercrunch and @dhuang to be potential reviewers. |
Author
|
And apparently there are no longer any landscape builds, so now I'm lost into what needs to be fixed? :-( |
alekstorm
pushed a commit
to alekstorm/incubator-airflow
that referenced
this pull request
Jun 1, 2017
- Add BROKER_USE_SSL config to give option to send AMQP messages over SSL - Can be set using usual airflow options (e.g. airflow.cfg, env vars, etc.) Closes apache#2333 from forsberg/ssl_amqp
Member
|
Isn't this going to break if the config doesn't define Should there be a change to the default generated config to add And also there's Edit: Someone has already opened a PR to fix this - #2341 |
stverhae
pushed a commit
to stverhae/incubator-airflow
that referenced
this pull request
Jun 6, 2017
- Add BROKER_USE_SSL config to give option to send AMQP messages over SSL - Can be set using usual airflow options (e.g. airflow.cfg, env vars, etc.) Closes apache#2333 from forsberg/ssl_amqp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Airflow maintainers,
This is a rebase + squash of #1905. I will now wait for the landscape build (as the previous one seems to have purged), then try to fix the landscape issues.