Mark image as refreshed when pulled on CI#23410
Merged
potiuk merged 1 commit intoapache:mainfrom May 2, 2022
Merged
Conversation
One of the recent changes in Breeze (apache#23395) caused unnecessary rebuilding of image when "build-docs" is run. On CI we build image once and reuse it. However in case of Buld docs we missed information that the image is "fresh" and we started rebuilding it. This change marks the image as "refreshed" when it is pulled with `--tag-as-latest` flag (which happens in CI).
eladkal
approved these changes
May 2, 2022
github-actions
bot
added
the
okay to merge
|
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Member
Author
|
6 minutes per docs-build saved :) |
potiuk
added a commit
that referenced
this pull request
May 7, 2022
One of the recent changes in Breeze (#23395) caused unnecessary rebuilding of image when "build-docs" is run. On CI we build image once and reuse it. However in case of Buld docs we missed information that the image is "fresh" and we started rebuilding it. This change marks the image as "refreshed" when it is pulled with `--tag-as-latest` flag (which happens in CI). (cherry picked from commit ce4a60c)
potiuk
added a commit
that referenced
this pull request
May 12, 2022
One of the recent changes in Breeze (#23395) caused unnecessary rebuilding of image when "build-docs" is run. On CI we build image once and reuse it. However in case of Buld docs we missed information that the image is "fresh" and we started rebuilding it. This change marks the image as "refreshed" when it is pulled with `--tag-as-latest` flag (which happens in CI). (cherry picked from commit ce4a60c)
ephraimbuddy
added
the
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
May 21, 2022
One of the recent changes in Breeze (#23395) caused unnecessary rebuilding of image when "build-docs" is run. On CI we build image once and reuse it. However in case of Buld docs we missed information that the image is "fresh" and we started rebuilding it. This change marks the image as "refreshed" when it is pulled with `--tag-as-latest` flag (which happens in CI). (cherry picked from commit ce4a60c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the recent changes in Breeze (#23395) caused unnecessary
rebuilding of image when "build-docs" is run. On CI we build
image once and reuse it. However in case of Buld docs we missed
information that the image is "fresh" and we started rebuilding
it. This change marks the image as "refreshed" when it is pulled
with
--tag-as-latestflag (which happens in CI).^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.