[AIRFLOW-1274][HttpSensor] Rename parameter params to data#2342
Closed
aliceabe wants to merge 1 commit intoapache:masterfrom
aliceabe:master
Closed
[AIRFLOW-1274][HttpSensor] Rename parameter params to data#2342aliceabe wants to merge 1 commit intoapache:masterfrom aliceabe:master
aliceabe wants to merge 1 commit intoapache:masterfrom
aliceabe:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2342 +/- ##
=========================================
Coverage ? 69.45%
=========================================
Files ? 144
Lines ? 11041
Branches ? 0
=========================================
Hits ? 7668
Misses ? 3373
Partials ? 0
Continue to review full report at Codecov.
|
aoen
reviewed
Jun 2, 2017
Contributor
There was a problem hiding this comment.
Nit: Can we call these request_params or something instead? I think this is a more logical name.
Contributor
|
Thank you for making this fix! |
Contributor
|
LGTM |
stverhae
pushed a commit
to stverhae/incubator-airflow
that referenced
this pull request
Jun 6, 2017
Renamed the parameter `params` to `request_params` in `HttpSensor` as it was conflicting with `BaseOperator` `params` and causing failed DAGs parsing. Closes apache#2342 from aliceabe/master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
No UI changes, I've just renamed the parameter
paramstorequest_paramsinHttpSensoras it was conflicting withBaseOperatorparamsand causing failed DAGs parsing.Tests
They already exist.
Commits
@saguziel @aoen