Closed
Conversation
boring-cyborg
bot
added
area:dev-tools
area:providers
area:UI
kazanzhy
force-pushed
the
add_apache_pulsar_hook
branch
from
9d822a6 to
a34b8cf
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a high-level question about this integration.
How to implement this hook?
The first way is similar to PubSubHook when all functionality is in the hook. Like PubSubHook.publish().
The second way is similar to FirehoseHook when the hook is just a wrapper of the boto client which is used to interact with Kinesis.
I think that the second way is preferable due to Pulsar client could reuse connections for producers and consumers